-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(trace) break up the rendering logic #77953
Conversation
ref(trace) break up the rendering logic
8d7a2a8
to
7bff424
Compare
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
55523aa
to
19e0876
Compare
} | ||
|
||
if (isTraceErrorNode(props.node)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tldr is that each of these just got moved into a separate file
Split loading and path logic to separate hooks
Bundle ReportChanges will increase total bundle size by 5.76kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Break up the trace rendering logic from one single file to separate row rendering methods and centralize props definition