Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(trace) break up the rendering logic #77953

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

ref(trace) break up the rendering logic #77953

wants to merge 4 commits into from
+1,344 −1,100

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Sep 23, 2024

Break up the trace rendering logic from one single file to separate row rendering methods and centralize props definition

@JonasBa JonasBa requested a review from a team as a code owner September 23, 2024 15:43
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 23, 2024
@JonasBa
ref(trace) break up the rendering logic
7bff424 
ref(trace) break up the rendering logic
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
7849 1 7848 0
View the top 1 failed tests by shortest run time 
trace view keyboard navigation roving updates the element in the drawer trace view keyboard navigation roving updates the element in the drawer
Stack Traces | 2.18s run time 
Error: expect(element).toHaveFocus()

Expected element with focus:
  <div class="TraceRow   " style="position: absolute; transform: translate(0px, 48px);" tabindex="-1"><div class="TraceLeftColumn"><div class="TraceLeftColumnInner" style="padding-left: 22px; transform: translateX(0px);"><div class="TraceChildrenCountWrapper Orphaned"><span class="TraceVerticalConnector Orphaned" style="left: 0px;" /><span class="TraceVerticalConnector" /><button class="TraceChildrenCount"><div class="TraceChildrenCountContent" /><div class="TraceChildrenCountAction">+</div></button></div><img height="20" src="[object Object]" style="border-radius: 3px;" width="20" /><span class="TraceOperation">transaction-op-1</span><strong class="TraceEmDash"> — </strong><span>transaction-name1</span></div></div><div class="TraceRightColumn"><div class="TraceBar" style="transform: matrix(Infinity,0,0,1,0,0; --inverse-span-scale: 0; background-color: rgb(134, 81, 137); --inverse-span-scale: 0;" /><div class="TraceBarDuration" style="transform: translateX(2px);">1.00s</div><button class="TraceArrow"><svg style="transform: rotate(-90deg);" viewBox="0 0 16 16"><path d="M14,11.75a.74.74,0,0,1-.53-.22L8,6.06,2.53,11.53a.75.75,0,0,1-1.06-1.06l6-6a.75.75,0,0,1,1.06,0l6,6a.75.75,0,0,1,0,1.06A.74.74,0,0,1,14,11.75Z" /></svg></button></div></div>
Received element with focus:
  <div class="TraceRow   " style="position: absolute; transform: translate(0px, 48px);" tabindex="0"><div class="TraceLeftColumn"><div class="TraceLeftColumnInner" style="padding-left: 44px; transform: translateX(-16px);"><div class="TraceChildrenCountWrapper"><span class="TraceVerticalConnector Orphaned" style="left: -22px;" /><span class="TraceVerticalLastChildConnector" /></div><span class="TraceOperation">special-span</span><strong class="TraceEmDash"> — </strong><span class="TraceDescription" title="">0</span></div></div><div class="TraceRightColumn"><div class="TraceBar" style="transform: matrix(Infinity,0,0,1,0,0; --inverse-span-scale: 0; background-color: rgb(116, 79, 136);" /><div class="TraceBarDuration" style="color: white; transform: translateX(-8px);">10.00s</div><button class="TraceArrow"><svg style="transform: rotate(-90deg);" viewBox="0 0 16 16"><path d="M14,11.75a.74.74,0,0,1-.53-.22L8,6.06,2.53,11.53a.75.75,0,0,1-1.06-1.06l6-6a.75.75,0,0,1,1.06,0l6,6a.75.75,0,0,1,0,1.06A.74.74,0,0,1,14,11.75Z" /></svg></button></div></div>

Ignored nodes: comments, script, style
...
    at .../performance/newTraceDetails/trace.spec.tsx:735:69
    at runWithExpensiveErrorDiagnosticsDisabled (.../sentry/sentry/node_modules/@.../dom/dist/config.js:47:12)
    at checkCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:124:77)
    at MutationObserver.checkRealTimersCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:118:16)
    at MutationObserver.invokeTheCallbackFunction (.../sentry/sentry/node_modules/jsdom/lib/jsdom/living/generated/MutationCallback.js:19:26)
    at notifyMutationObservers (.../sentry/sentry/node_modules/jsdom/lib/jsdom/living/helpers/mutation-observers.js:160:22)
    at .../sentry/sentry/node_modules/jsdom/lib/jsdom/living/helpers/mutation-observers.js:133:5

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

JonasBa
JonasBa commented Sep 23, 2024
View reviewed changes
static/app/views/performance/newTraceDetails/trace.tsx
}

if (isTraceErrorNode(props.node)) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tldr is that each of these just got moved into a separate file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JonasBa