Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(trace) break up the rendering logic #77953

Merged
merged 13 commits into from
Sep 27, 2024
Merged

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Sep 23, 2024

Break up the trace rendering logic from one single file to separate row rendering methods and centralize props definition

@JonasBa JonasBa requested a review from a team as a code owner September 23, 2024 15:43
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 23, 2024
ref(trace) break up the rendering logic
Copy link

codecov bot commented Sep 23, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
7854 1 7853 0
View the top 1 failed tests by shortest run time
StacktraceLink renders nothing when missing integrations StacktraceLink renders nothing when missing integrations
Stack Traces | 1.43s run time
Error: expect(element).toBeEmptyDOMElement()

Received:
  "<div class=\"css-1mh8q72-StacktraceLinkWrapper ezlmato4\"><div data-test-id=\"loading-placeholder\" class=\"css-m5e5wk-Placeholder e2q81od0\"></div></div>"

Ignored nodes: comments, script, style
...
    at .../interfaces/frame/stacktraceLink.spec.tsx:70:25
    at runWithExpensiveErrorDiagnosticsDisabled (.../sentry/sentry/node_modules/@.../dom/dist/config.js:47:12)
    at checkCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:124:77)
    at checkRealTimersCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:118:16)
    at Timeout.task [as _onTimeout] (.../sentry/sentry/node_modules/jsdom/lib/jsdom/browser/Window.js:520:19)
    at listOnTimeout (node:internal/timers:573:17)
    at processTimers (node:internal/timers:514:7)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

}

if (isTraceErrorNode(props.node)) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tldr is that each of these just got moved into a separate file

Split loading and path logic to separate hooks
Copy link

codecov bot commented Sep 25, 2024

Bundle Report

Changes will increase total bundle size by 5.76kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 29.63MB 5.76kB (0.02%) ⬆️

@JonasBa JonasBa merged commit cd5895c into master Sep 27, 2024
42 of 43 checks passed
@JonasBa JonasBa deleted the jb/ref/trace-components branch September 27, 2024 16:10
Copy link

sentry-io bot commented Sep 27, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'captureMessage') //performance/trace/:traceSlug/ View Issue
  • ‼️ Error: Autogrouped node must have span children //performance/trace/:traceSlug/ View Issue
  • ‼️ TypeError: undefined is not an object (evaluating 'Pn.default.captureMessage') //performance/trace/:traceSlug/ View Issue
  • ‼️ TypeError: Node path must be in the format of type-id //performance/trace/:traceSlug/ View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants