Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp(spans): Remove numeric attr tests for now #77970

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

wmak
Copy link
Member

@wmak wmak commented Sep 23, 2024

  • Snuba changed the keys, will need to rewrite this functionality & tests

- Snuba changed the keys, will need to rewrite this functionality &
  tests
@wmak wmak requested a review from a team as a code owner September 23, 2024 19:00
Copy link
Member

@colin-sentry colin-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just pytest.disabled them?

@wmak wmak enabled auto-merge (squash) September 23, 2024 19:11
@wmak wmak merged commit e7cc9c4 into master Sep 23, 2024
46 checks passed
@wmak wmak deleted the wmak/temp/remove-num-attr-tests-for-now branch September 23, 2024 19:38
harshithadurai pushed a commit that referenced this pull request Sep 24, 2024
- Snuba changed the keys, will need to rewrite this functionality &
tests
0Calories pushed a commit that referenced this pull request Sep 25, 2024
- Snuba changed the keys, will need to rewrite this functionality &
tests
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants