Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(monitors): Remove icon from owner filter #77973

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Conversation

vuluongj20
Copy link
Member

Before —
Screenshot 2024-09-23 at 12 22 49 PM

After —
Screenshot 2024-09-23 at 12 23 05 PM

@vuluongj20 vuluongj20 requested a review from a team as a code owner September 23, 2024 19:23
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
7867 1 7866 0
View the top 1 failed tests by shortest run time
Sudo Modal shows button to redirect if user does not have password auth Sudo Modal shows button to redirect if user does not have password auth
Stack Traces | 0.058s run time
TestingLibraryElementError: Unable to find an accessible element with the role "button" and name "Continue"

Here are the accessible roles:

  dialog:

  Name "":
  ...

  --------------------------------------------------
  document:

  Name "":
  ...

  --------------------------------------------------
  banner:

  Name "":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../components/modals/sudoModal.spec.tsx:164:40)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:540:9)
    at processTimers (node:internal/timers:514:7)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@vuluongj20 vuluongj20 merged commit b124b78 into master Oct 9, 2024
42 checks passed
@vuluongj20 vuluongj20 deleted the vl/monitor-owner branch October 9, 2024 17:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants