Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deletions) Move ScheduledDeletion models to deletions #77974

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deletions) Move ScheduledDeletion models to deletions #77974

wants to merge 1 commit into from
+240 −220

Conversation

markstory
Copy link
Member

Move the ScheduledDeletion model classes into sentry.deletions so that all the deletion code is co-located.

Refs #77479

@markstory
chore(deletions) Move ScheduledDeletion models to deletions
6b9ca7f 
Move the `ScheduledDeletion` model classes into `sentry.deletions` so
that all the deletion code is co-located.

Refs #77479
@markstory markstory requested review from a team September 23, 2024 19:37
@markstory markstory requested review from a team as code owners September 23, 2024 19:37
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 23, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

❌ 11 Tests Failed:

Tests completed Failed Passed Skipped
21637 11 21626 206
View the full list of 3 ❄️ flaky tests 
tests.snuba.api.endpoints.test_organization_events_span_indexed.OrganizationEventsEAPSpanEndpointTest test_sentry_tags_vs_tags

Flake rate in main: 40.91% (Passed 13 times, Failed 9 times)

Stack Traces | 16.9s run time 
#x1B[1m#x1B[.../api/endpoints/test_organization_events_span_indexed.py#x1B[0m:134: in test_sentry_tags_vs_tags
    assert data[0]["transaction.method"] == "foo"
#x1B[1m#x1B[31mE   AssertionError: assert '' == 'foo'#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     - foo#x1B[0m

tests.snuba.api.endpoints.test_organization_events_span_indexed.OrganizationEventsEAPSpanEndpointTest test_span_op_casing

Flake rate in main: 40.91% (Passed 13 times, Failed 9 times)

Stack Traces | 16.9s run time 
#x1B[1m#x1B[.../api/endpoints/test_organization_events_span_indexed.py#x1B[0m:408: in test_span_op_casing
    assert len(data) == 1
#x1B[1m#x1B[31mE   assert 0 == 1#x1B[0m
#x1B[1m#x1B[31mE    +  where 0 = len([])#x1B[0m

tests.snuba.api.endpoints.test_organization_events_span_indexed.OrganizationEventsEAPSpanEndpointTest test_inp_span

Flake rate in main: 40.91% (Passed 13 times, Failed 9 times)

Stack Traces | 17s run time 
#x1B[1m#x1B[.../api/endpoints/test_organization_events_span_indexed.py#x1B[0m:335: in test_inp_span
    assert len(data) == 1
#x1B[1m#x1B[31mE   assert 0 == 1#x1B[0m
#x1B[1m#x1B[31mE    +  where 0 = len([])#x1B[0m

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@markstory