Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pageFilters): Update min widths #77975

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix(pageFilters): Update min widths #77975

merged 2 commits into from
Sep 24, 2024

Conversation

vuluongj20
Copy link
Member

After #77867, we can set lower min width for page filters.

Before —
Screenshot 2024-09-23 at 12 38 04 PM

After —
Screenshot 2024-09-23 at 12 37 49 PM

@vuluongj20 vuluongj20 requested a review from a team as a code owner September 23, 2024 19:38
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 23, 2024
vuluongj20
vuluongj20 commented Sep 23, 2024
View reviewed changes
static/app/views/issueList/filters.tsx

& > * {
/* Prevent date filter from shrinking below 6.5rem */
&:nth-last-child(2) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wrongly selects the environment filter, which doesn't need a min width.

vuluongj20
vuluongj20 commented Sep 23, 2024
View reviewed changes
static/app/views/issueList/filters.tsx
}

&:last-child {
min-width: 0;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this selects the date filter, which already has a min width (in pageFilterBar.tsx)

@vuluongj20 vuluongj20 merged commit fa4d643 into master Sep 24, 2024
43 checks passed
@vuluongj20 vuluongj20 deleted the vl/page-filter-width branch September 24, 2024 17:49
@doralchan doralchan mentioned this pull request Sep 24, 2024
Closed
0Calories pushed a commit that referenced this pull request Sep 25, 2024
@vuluongj20 @0Calories
fix(pageFilters): Update min widths (#77975)
4af67cd 
After #77867, we can set lower
min width for page filters.

**Before —**
<img width="311" alt="Screenshot 2024-09-23 at 12 38 04 PM"
src="https://github.com/user-attachments/assets/28876dbf-c17e-4baa-be84-8697a990125a">


**After —**
<img width="275" alt="Screenshot 2024-09-23 at 12 37 49 PM"
src="https://github.com/user-attachments/assets/b3965201-c721-4bc4-8744-9e37b96e4ccd">
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scttcper scttcper scttcper approved these changes

@evanpurkhiser evanpurkhiser Awaiting requested review from evanpurkhiser

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vuluongj20 @scttcper