Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spans): Add missing functions for db view #78224

Closed
wants to merge 3 commits into from

Conversation

wmak
Copy link
Member

@wmak wmak commented Sep 26, 2024

  • Adds time_spent_percentage to the spans dataset
  • Adds http_response_count
  • Adds count_web_vitals

- Adds time_spent_percentage to the spans dataset
@wmak wmak requested review from a team as code owners September 26, 2024 18:26
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 26, 2024
@wmak wmak changed the title fix(spans): Add time spent percentage fix(spans): Add missing functions for db view Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 58.62069% with 12 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/search/events/datasets/spans_indexed.py 58.62% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #78224      +/-   ##
==========================================
- Coverage   78.10%   78.10%   -0.01%     
==========================================
  Files        7038     7038              
  Lines      311549   311573      +24     
  Branches    50924    50930       +6     
==========================================
+ Hits       243347   243355       +8     
- Misses      56450    56466      +16     
  Partials    11752    11752              

Copy link
Member

@0Calories 0Calories left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@getsantry
Copy link
Contributor

getsantry bot commented Oct 23, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 23, 2024
@getsantry getsantry bot closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants