Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(streamline): Prototype alternative layout #78402

Closed
wants to merge 5 commits into from
Closed

ref(streamline): Prototype alternative layout #78402

wants to merge 5 commits into from

Conversation

leeandher
Copy link
Member

@leeandher leeandher commented Oct 1, 2024 •
edited
Loading

Not actually meant to be reviewed, just getting a vercel preview.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 1, 2024
@leeandher leeandher marked this pull request as ready for review October 1, 2024 17:55
@leeandher leeandher requested a review from a team as a code owner October 1, 2024 17:55
@codecov Codecov
Copy link

codecov bot commented Oct 1, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 33.45kB (0.11%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 30.67MB 33.45kB (0.11%) ⬆️

@codecov Codecov
Copy link

codecov bot commented Oct 1, 2024

❌ 18 Tests Failed:

Tests completed Failed Passed Skipped
7905 18 7887 0
View the top 3 failed tests by shortest run time 
NewIssueExperienceButton triggers changes to the user config and location NewIssueExperienceButton triggers changes to the user config and location
Stack Traces | 0.026s run time 
TestingLibraryElementError: Unable to find an accessible element with the role "button" and name "Switch to the new issue experience"

Here are the accessible roles:

  button:

  Name "Switch to the new issue view":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../issueDetails/actions/newIssueExperienceButton.spec.tsx:81:48)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

IssueContent displays the extra data sections as closed by default IssueContent displays the extra data sections as closed by default
Stack Traces | 0.042s run time 
Error: expect(element).not.toBeInTheDocument()

expected document not to contain element, found <h4 class="css-1258ngj-Title e1jyh1ck1">Fingerprints included in this issue </h4> instead
    at Object.<anonymous> (.../issueDetails/streamline/issueContent.spec.tsx:47:96)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:540:9)
    at processTimers (node:internal/timers:514:7)

EventNavigation can runs callback on view all events click EventNavigation can runs callback on view all events click
Stack Traces | 0.082s run time 
TestingLibraryElementError: Unable to find an accessible element with the role "button" and name "View All Events"

Here are the accessible roles:

  tablist:

  Name "":
  ...

  --------------------------------------------------
  tab:

  Name "Recommended Event":
  ...

  Name "First Event":
  ...

  Name "Last Event":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  button:

  Name "Previous Event":
  ...

  Name "Next Event":
  ...

  Name "Copy":
  ...

  Name "Event actions":
  ...

  Name "Event Highlights":
  ...

  Name "Tags":
  ...

  Name "Replay":
  ...

  --------------------------------------------------
  time:

  Name "":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../issueDetails/streamline/eventNavigation.spec.tsx:134:55)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@getsantry
Copy link
Contributor

getsantry bot commented Oct 23, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 23, 2024
@leeandher leeandher closed this Oct 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leeandher