Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(metrics): remove create alert and create widget actions #78603

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

obostjancic
Copy link
Member

@obostjancic obostjancic commented Oct 4, 2024

Without custom metrics flag:
image

@obostjancic obostjancic requested a review from a team as a code owner October 4, 2024 08:11
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 4, 2024
@obostjancic obostjancic self-assigned this Oct 4, 2024
@obostjancic obostjancic added the Do Not Merge Don't merge label Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 22.80702% with 44 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tatic/app/views/metrics/metricQueryContextMenu.tsx 20.58% 27 Missing ⚠️
static/app/views/metrics/pageHeaderActions.tsx 31.25% 11 Missing ⚠️
static/app/views/metrics/metricsBetaEndAlert.tsx 33.33% 2 Missing ⚠️
...ponents/modals/metricWidgetViewerModal/queries.tsx 0.00% 1 Missing ⚠️
static/app/views/dashboards/dashboard.tsx 0.00% 1 Missing ⚠️
static/app/views/dashboards/widgetCard/index.tsx 0.00% 1 Missing ⚠️
...p/views/settings/projectMetrics/projectMetrics.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #78603      +/-   ##
==========================================
- Coverage   78.13%   78.13%   -0.01%     
==========================================
  Files        7098     7098              
  Lines      312860   312869       +9     
  Branches    51103    51103              
==========================================
+ Hits       244463   244470       +7     
- Misses      62020    62022       +2     
  Partials     6377     6377              

@obostjancic obostjancic linked an issue Oct 4, 2024 that may be closed by this pull request
@obostjancic obostjancic merged commit 86f5776 into master Oct 4, 2024
43 of 44 checks passed
@obostjancic obostjancic deleted the ogi/chore/metrics-remove-create-edit-actions-v2 branch October 4, 2024 13:53
@obostjancic obostjancic removed the Do Not Merge Don't merge label Oct 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DDM Beta end
2 participants