ref(ownership): refactor post_process telemetry

[JoshFerge]

I was finding this code very hard to read with all of the telemetry context creations and indentation. No behavior changes intended.

• Taking advantage of metrics.wraps and sentry_sdk.trace we can get rid of most of these.
• Additionally, i've removed the spans around the caching operations as all of our cache get / sets get instrumented with spans anways.
• Utilize return early pattern to prevent more nesting
• we don't need a wrapper to try / except the whole function as post process already does this

  sentry/src/sentry/tasks/post_process.py

  Line 692 in 020c9f4

  try:

[snigdhas]

do we need to go through handle_invalid_group_owners in this branch? the old code without the early-return would eventually call handle_invalid_group_owners(group).

[snigdhas]

although imo if the killswitch is set, returning without doing anything seems like the right call

[JoshFerge]

yeah, this is a fair point. it is a behavior change. i'll modify the function to call handle_invalid_group_owners. i feel suspicious about even hitting that if the killswitch is activated, but will keep the same.

[JoshFerge]

went ahead and changed that else back

[codecov]

Codecov Report

Attention: Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/sentry/tasks/post_process.py	88.57%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #78979      +/-   ##
==========================================
- Coverage   78.29%   78.29%   -0.01%     
==========================================
  Files        7130     7128       -2     
  Lines      313632   313603      -29     
  Branches    51170    51172       +2     
==========================================
- Hits       245568   245541      -27     
+ Misses      61650    61644       -6     
- Partials     6414     6418       +4