-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create rc-processing-transaction #79200
Conversation
there's a lot of places in code where you need to implement the dual writing, have you considered putting the dual writing logic in one place only inside the |
Co-authored-by: Lyn Nagara <1779792+lynnagara@users.noreply.github.com>
Co-authored-by: Lyn Nagara <1779792+lynnagara@users.noreply.github.com>
i think there are a few more places in the codebase where this is needed.. e.g. sentry/src/sentry/event_manager.py Lines 1104 to 1107 in 939be86
can you check the whole codebase? |
that is from the
The rest of the references in the codebase are test cases (and reprocessing, which I'm not sure if it needs to be updated) but I think they don't need to know about the split |
src/sentry/eventstream/types.py
Outdated
@@ -0,0 +1,8 @@ | |||
class EventStreamEventType: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the reason was related to celery task pickling. We could put the string version of the enum values into task messages though.
PR reverted: 56b7027 |
This reverts commit cb14959. Co-authored-by: bmckerry <110857332+bmckerry@users.noreply.github.com>
This creates rc processing transactions redis cluster specifically for transactions. For now as part of the rollout, this only initializes the new eventstore and refactors a lot of the code so that most of the processing and post processing is aware of the event type.
This reverts commit cb14959. Co-authored-by: bmckerry <110857332+bmckerry@users.noreply.github.com>
repeat of #79200 This splits up that PR so that we change `save_event` first before the kafka consumers. --------- Co-authored-by: Mark Story <mark@mark-story.com>
Part of splitting up the event_processing store. see #79200
Post Process is unaware of the event type, this makes picking the correct eventstore harder. This is part of #79200
This creates rc processing transactions redis cluster specifically for transactions. For now as part of the rollout, this only initializes the new eventstore and refactors a lot of the code so that most of the processing and post processing is aware of the event type.