ref(alerts): Move action check to serializer and remove signals #79389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
mifu67
approved these changes
Oct 21, 2024
saponifi3d
reviewed
Oct 21, 2024
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
Another small cleanup as I look through this code for the ACI spec. Move the check for an action for each trigger to the serializer, and remove the signals we aren't using anymore. I double checked with the support and CSMs that they're not using the signals for anything.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small cleanup as I look through this code for the ACI spec. Move the check for an action for each trigger to the serializer, and remove the signals we aren't using anymore. I double checked with the support and CSMs that they're not using the signals for anything.