Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(sentry-sdk): Enable HTTP2 transport" #79391

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

ellisonmarks
Copy link
Contributor

Reverts #79278

It's possible that this caused S4S to stop getting data from sentry.

@ellisonmarks ellisonmarks requested a review from a team as a code owner October 18, 2024 23:34
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 18, 2024
@ellisonmarks ellisonmarks enabled auto-merge (squash) October 18, 2024 23:38
@ellisonmarks ellisonmarks merged commit e88eae1 into master Oct 19, 2024
50 checks passed
@ellisonmarks ellisonmarks deleted the revert-79278-byk/feat/enable-http2-sdk branch October 19, 2024 00:47
harshithadurai pushed a commit that referenced this pull request Oct 19, 2024
Reverts #79278

It's possible that this caused S4S to stop getting data from sentry.
priscilawebdev pushed a commit that referenced this pull request Oct 20, 2024
Reverts #79278

It's possible that this caused S4S to stop getting data from sentry.

feat(whats-new): Add new onboarding sidebar

remove animation
jan-auer added a commit that referenced this pull request Oct 21, 2024
* master: (288 commits)
  feat(metrics): Register MRI for spans/count_per_root_project (#78992)
  feat(dynamic-sampling): Settings for sample rate (#79341)
  Revert "feat(sentry-sdk): Enable HTTP2 transport" (#79391)
  fix(feedback): keep oldest date_added for duplicate user reports (#79387)
  chore(issue-stream): Remove tooltip for Unhandled (#79385)
  chore(autofix): Show banner if gen AI consent is given, even if no feature flag (#79362)
  chore(autofix+copilot) Allow autofix without FF if gen AI consent given (#79361)
  Fixes VULN-50 by enforcing option (#79384)
  perf(issues): improve adjacent_events query (#79365)
  feat(issues): Add anchor links back to issue sections (#79333)
  fix(issue-views): Make tab bar take up entire row (#79383)
  chore(issues): Add additional metrics for ownership matching (#79302)
  feat(insights): create screen rendering module (#79192)
  fix(issues): Avoid streamline issue layout rerenders (#79327)
  ref(performance): Add missing types to performance widgets (#79301)
  chore(issue-views): Add translation wrapper to aria label (#79320)
  chore(issue-stream): Reduce font size of title and message (#79378)
  feat(insights): update headers and breadcrumbs on frontend domain view (#78945)
  feat(insights): add view trends button to ai overview (#78611)
  ref(rr6): Remove unused param (#79379)
  ...
kneeyo1 pushed a commit that referenced this pull request Oct 21, 2024
Reverts #79278

It's possible that this caused S4S to stop getting data from sentry.
cmanallen pushed a commit that referenced this pull request Oct 23, 2024
Reverts #79278

It's possible that this caused S4S to stop getting data from sentry.
@BYK
Copy link
Member

BYK commented Oct 24, 2024

Context from the future: this indeed broke S4S connections because we did not have the h2 package installed and there was a bug in the graceful fallback mechanism in the SDK: sentry-python#3690

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants