Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(quick-start): Remove the basics step #79393

Merged

Conversation

priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Oct 20, 2024

Problem

When new users create a project, the quick start sidebar shows a step called "The Basics" with a message saying Sentry is waiting for an error. However, there are some issues:

  1. The "The Basics" card has a close button, suggesting users can skip this step. But generating an error is an important action we want users to complete.
  2. Clicking on the project name takes users back to the start of the onboarding flow, but it should direct them to the platform's "Getting Started" documentation instead.
  3. The skip button on the card does not work.
  4. In the "Next Steps" section, the first card also says "Waiting for an error" but doesn’t have a close button. This is confusing because both cards are about the same thing.

The "The Basics" step made sense when users could set up multiple platforms during onboarding. However, since this feature was removed in this PR, the step is no longer relevant.

Screen.Recording.2024-10-19.at.23.23.18.mov

Solution

We are currently reformulating the Quick Start but for now, we can remove the "The Basics" step. By doing this, a card "Create a Project" is shown in the "Next Steps"

image image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 20, 2024
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
static/app/components/sidebar/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #79393      +/-   ##
==========================================
- Coverage   79.27%   78.21%   -1.06%     
==========================================
  Files        7307     7131     -176     
  Lines      324623   315114    -9509     
  Branches    51516    51514       -2     
==========================================
- Hits       257347   246475   -10872     
+ Misses      65088    61761    -3327     
- Partials     2188     6878    +4690     

remove onskip prop

remove renderCard checks
@priscilawebdev priscilawebdev force-pushed the priscila/fix/quick-start/remove-the-basic-steps branch from c89eff9 to 27c2f9c Compare October 20, 2024 03:10
@priscilawebdev priscilawebdev marked this pull request as ready for review October 21, 2024 08:28
@priscilawebdev priscilawebdev requested a review from a team as a code owner October 21, 2024 08:28
@priscilawebdev priscilawebdev requested a review from a team October 21, 2024 08:28
@priscilawebdev priscilawebdev merged commit 8e16450 into master Oct 22, 2024
44 checks passed
@priscilawebdev priscilawebdev deleted the priscila/fix/quick-start/remove-the-basic-steps branch October 22, 2024 10:24
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants