Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: upgrade mypy to 1.12.x #79587

Merged
merged 1 commit into from
Oct 23, 2024
Merged

ref: upgrade mypy to 1.12.x #79587

merged 1 commit into from
Oct 23, 2024

Conversation

asottile-sentry
Copy link
Member

No description provided.

@asottile-sentry asottile-sentry requested review from a team October 23, 2024 13:52
@asottile-sentry asottile-sentry requested a review from a team as a code owner October 23, 2024 13:52
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 23, 2024
@asottile-sentry asottile-sentry enabled auto-merge (squash) October 23, 2024 13:53
@asottile-sentry asottile-sentry enabled auto-merge (squash) October 23, 2024 14:15
@asottile-sentry asottile-sentry merged commit a19c646 into master Oct 23, 2024
48 checks passed
@asottile-sentry asottile-sentry deleted the asottile-upgrade-mypy branch October 23, 2024 14:48
@asottile-sentry
Copy link
Member Author

merge race with #79510

@asottile-sentry asottile-sentry added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Oct 23, 2024
@asottile-sentry
Copy link
Member Author

fix in #79602

@getsentry-bot
Copy link
Contributor

PR reverted: 9e3fe7d

getsentry-bot added a commit that referenced this pull request Oct 23, 2024
@getsentry-bot @asottile-sentry
Revert "ref: upgrade mypy to 1.12.x (#79587)"
9e3fe7d 
This reverts commit a19c646.

Co-authored-by: asottile-sentry <103459774+asottile-sentry@users.noreply.github.com>
asottile-sentry added a commit that referenced this pull request Oct 23, 2024
@asottile-sentry
Reapply "ref: upgrade mypy to 1.12.x (#79587)"
994ce41 
This reverts commit 9e3fe7d.
@asottile-sentry asottile-sentry mentioned this pull request Oct 23, 2024
Merged
cmanallen pushed a commit that referenced this pull request Oct 23, 2024
@asottile-sentry @cmanallen
ref: upgrade mypy to 1.12.x (#79587)
9bd1ed8 
<!-- Describe your PR here. -->
cmanallen pushed a commit that referenced this pull request Oct 23, 2024
@getsentry-bot @asottile-sentry @cmanallen
Revert "ref: upgrade mypy to 1.12.x (#79587)"
3db6946 
This reverts commit a19c646.

Co-authored-by: asottile-sentry <103459774+asottile-sentry@users.noreply.github.com>
asottile-sentry added a commit that referenced this pull request Oct 24, 2024
@asottile-sentry
Reapply "ref: upgrade mypy to 1.12.x (#79587)"
3da151f 
This reverts commit 9e3fe7d.
asottile-sentry added a commit that referenced this pull request Oct 24, 2024
@asottile-sentry
Reapply "ref: upgrade mypy to 1.12.x (#79587)" (#79616)
c33c8cf 
This reverts commit 9e3fe7d.

original (#79587) suffered a merge race -- this was fixed and so no
additional code changes are necessary for the reapply

<!-- Describe your PR here. -->
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armenzg armenzg armenzg approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asottile-sentry @getsentry-bot @armenzg