fix(on-demand-metrics): Correctly handle computed contexts #80061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80061 +/- ##
==========================================
+ Coverage 78.11% 78.17% +0.05%
==========================================
Files 7157 7172 +15
Lines 316569 317802 +1233
Branches 43642 43800 +158
==========================================
+ Hits 247276 248428 +1152
- Misses 62946 63007 +61
- Partials 6347 6367 +20 |
This was referenced Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR correctly handles computed contexts and fields in the form
tags[*]. The previous implementation was wrong (my bad) and I realized this too late.This change shouldn't need versioning since existing on-demand widgets and alerts are broken meaning that we do not need to collect 90 days of data before moving over.
Needs: getsentry/relay#4239
Related to: getsentry/relay#4205