-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(profiling): emit (processed) profile outcomes in profiling consumers #80189
ref(profiling): emit (processed) profile outcomes in profiling consumers #80189
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80189 +/- ##
==========================================
- Coverage 78.09% 78.08% -0.01%
==========================================
Files 7178 7176 -2
Lines 317128 317142 +14
Branches 43719 43722 +3
==========================================
+ Hits 247649 247651 +2
+ Misses 63136 63135 -1
- Partials 6343 6356 +13 |
…tcomes-in-profiling-consumers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
process_profile_task
has a lot of code paths that exit/return without emitting an outcome, all of these cases now would never emit an outcome, I don't think this is desired, I assume that these at least should be counted in some error category.
@Dav1dde as we discussed quickly over slack, all the early return are taken care of (inside the functions body when we catch the exception). The only place where we return early and not emit an outcome is here at the very beginning where we |
This closes issue https://github.com/getsentry/team-ingest/issues/563