Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failsafe in case config for transaction_processing_store is incorrect #80463

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

kneeyo1
Copy link
Contributor

@kneeyo1 kneeyo1 commented Nov 8, 2024

If the transactions configuration is wrong for any reason, fall back to the default processing memorystore.

@kneeyo1 kneeyo1 changed the title Failsafe in case config for transaction_processing_store is incorrect… Failsafe in case config for transaction_processing_store is incorrect Nov 8, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/eventstore/processing/__init__.py 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #80463      +/-   ##
==========================================
- Coverage   78.36%   78.36%   -0.01%     
==========================================
  Files        7207     7207              
  Lines      318765   318770       +5     
  Branches    43918    43918              
==========================================
+ Hits       249787   249790       +3     
- Misses      62611    62615       +4     
+ Partials     6367     6365       -2     

@kneeyo1 kneeyo1 marked this pull request as ready for review November 11, 2024 17:18
@lynnagara
Copy link
Member

lynnagara commented Nov 11, 2024

Can you provide more context about the rationale for this? Is this intended to be temporary? Why does it only cover the transaction store and not invalid config of the event store

If this is intended as a validation mechanism, I think it would make more sense to build a proper validation that covers both events and transactions processing stores instead of this fallback which is quite unexpected.

@kneeyo1
Copy link
Contributor Author

kneeyo1 commented Nov 11, 2024

Can you provide more context about the rationale for this? Is this intended to be temporary? Why does it only cover the transaction store and not invalid config of the event store

If this is intended as a validation mechanism, I think it would make more sense to build a proper validation that covers both events and transactions processing stores instead of this fallback which is quite unexpected.

Yes, this is intended to be temporary, I think the proper fix would be fixing how the eventstores are properly initalized, but out of scope for this project :(

@kneeyo1 kneeyo1 merged commit 59bf9d8 into master Nov 11, 2024
49 of 50 checks passed
@kneeyo1 kneeyo1 deleted the safer-rollout-transactions branch November 11, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants