Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(alerts): add test for edited query #80498

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

natemoo-re
Copy link
Member

This PR introduces a regression test for #80075.

It was reported that editing the query of an existing alert rule was broken, but we didn't have test coverage for this. Now we do!

@natemoo-re natemoo-re requested a review from a team as a code owner November 8, 2024 22:30
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #80498       +/-   ##
===========================================
+ Coverage   64.77%   78.34%   +13.56%     
===========================================
  Files        7198     7202        +4     
  Lines      318487   318655      +168     
  Branches    43903    43923       +20     
===========================================
+ Hits       206307   249653    +43346     
+ Misses     105500    62640    -42860     
+ Partials     6680     6362      -318     

Copy link
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎉

@natemoo-re natemoo-re enabled auto-merge (squash) November 8, 2024 23:15
@natemoo-re natemoo-re merged commit 2e3b5b3 into master Nov 8, 2024
44 checks passed
@natemoo-re natemoo-re deleted the test/query-update branch November 8, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants