Skip to content

Commit

Permalink
fix(replays): Align Rust schema with Python schema and add additional…
Browse files Browse the repository at this point in the history
… test coverage (#5342)

* Accept null tag values

* Tags are stored as a vector of string in the database

* Use unwrap or default

* Add coverage for null urls, traces, and errors vectors

* Accept optional user values

* Match schema one to one with the python processor

* The replay consumer can return multiple rows in a single request

* Re-enable replays processor

* Re-enable replays processor

* Don't wrap with array

* Use or chaining

* Use anyhow as the return type

* Remove expect

* Flatten match arms

* Update python processor to return the default values we expect

* Remove special handling for replays topic

* Serialize everything

* Default to empty string values

* Add custom processor comparison coverage

* Sort ReplayRow struct fields alphabetically

* Remove print

* Type ignore

* User now defaults to an empty string

* User and sdk values default to empty string

* Skip contexts if empty

* Remove event_hash changes

* Update test coverage

* Handle dynamically typed user_id field

* Allow replay

* Remove event_hash since it can be inconsistent without segment_id

---------

Co-authored-by: Pierre Massat <pierre.massat@sentry.io>
  • Loading branch information
cmanallen and phacops committed Jan 10, 2024
1 parent 25fa157 commit 7d65c90
Show file tree
Hide file tree
Showing 6 changed files with 668 additions and 226 deletions.
Loading

0 comments on commit 7d65c90

Please sign in to comment.