Skip to content

Commit

Permalink
feat(replays): add replay_id uuid processors to config (#5791)
Browse files Browse the repository at this point in the history
* feat(replays): add migration for replay_id in discover

* feat(replays): add replay_id uuid processors to config

* Update discover.yaml

* Update errors_ro.yaml

* Update errors.yaml

* Update group_loader.py

* Delete snuba/snuba_migrations/discover/0008_discover_add_replay_id.py

* Update group_loader.py
  • Loading branch information
JoshFerge committed Apr 18, 2024
1 parent eadc30b commit 8ede52a
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 15 deletions.
5 changes: 2 additions & 3 deletions snuba/datasets/configuration/discover/storages/discover.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ schema:
args: { schema_modifiers: [nullable], size: 64 },
},
{ name: deleted, type: UInt, args: { size: 8 } },
{ name: replay_id, type: UUID, args: { schema_modifiers: [nullable] } }
]
local_table_name: discover_local
dist_table_name: discover_dist
Expand Down Expand Up @@ -115,9 +116,7 @@ query_processors:
column_name: tags
- processor: UUIDColumnProcessor
args:
columns: !!set
trace_id: null
event_id: null
columns: [event_id, trace_id, replay_id]
- processor: HexIntColumnProcessor
args:
columns: !!set
Expand Down
6 changes: 1 addition & 5 deletions snuba/datasets/configuration/events/storages/errors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ allocation_policies:
getsentry.tasks.backfill_grouping_records:
max_threads: 2
concurrent_limit: 4

query_processors:
- processor: UniqInSelectAndHavingProcessor
- processor: TupleUnaliaser
Expand All @@ -303,10 +302,7 @@ query_processors:
- processor: UserColumnProcessor
- processor: UUIDColumnProcessor
args:
columns: !!set
event_id: null
primary_hash: null
trace_id: null
columns: [event_id, primary_hash, trace_id, replay_id]
- processor: HexIntColumnProcessor
args:
columns: !!set
Expand Down
7 changes: 1 addition & 6 deletions snuba/datasets/configuration/events/storages/errors_ro.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,6 @@ allocation_policies:
getsentry.tasks.backfill_grouping_records:
max_threads: 2
concurrent_limit: 4


query_processors:
- processor: UniqInSelectAndHavingProcessor
- processor: TupleUnaliaser
Expand All @@ -302,10 +300,7 @@ query_processors:
- processor: UserColumnProcessor
- processor: UUIDColumnProcessor
args:
columns: !!set
primary_hash: null
event_id: null
trace_id: null
columns: [event_id, primary_hash, trace_id, replay_id]
- processor: HexIntColumnProcessor
args:
columns: !!set
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ schema:
},
{ name: app_start_type, type: String },
{ name: profile_id, type: UUID, args: { schema_modifiers: [nullable] } },
{ name: replay_id, type: UUID, args: { schema_modifiers: [nullable] } },
]
local_table_name: transactions_local
dist_table_name: transactions_dist
Expand Down Expand Up @@ -202,7 +203,7 @@ query_processors:
trace.span_id: span_id
- processor: UUIDColumnProcessor
args:
columns: [event_id, trace_id, profile_id]
columns: [event_id, trace_id, profile_id, replay_id]
- processor: HexIntColumnProcessor
args:
columns: [span_id]
Expand Down

0 comments on commit 8ede52a

Please sign in to comment.