Skip to content

Commit

Permalink
show nodes migration is applied on (#4388)
Browse files Browse the repository at this point in the history
* show nodes migration is applied on

* show node type
  • Loading branch information
dbanda committed Jun 22, 2023
1 parent 8100960 commit 94fa31a
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions snuba/migrations/operations.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,16 @@
from enum import Enum
from typing import Any, Callable, Mapping, Optional, Sequence, Tuple

import structlog

from snuba.clickhouse.columns import Column
from snuba.clusters.cluster import ClickhouseClientSettings, get_cluster
from snuba.clusters.storage_sets import StorageSetKey
from snuba.migrations.columns import MigrationModifiers
from snuba.migrations.table_engines import TableEngine

logger = structlog.get_logger().bind(module=__name__)


class OperationTarget(Enum):
"""
Expand Down Expand Up @@ -49,12 +53,13 @@ def execute(self) -> None:
nodes = dist_nodes
else:
raise ValueError(f"Target not set for {self}")

if nodes:
logger.info(f"Executing op: {self.format_sql()[:32]}...")
for node in nodes:
connection = cluster.get_node_connection(
ClickhouseClientSettings.MIGRATE, node
)

logger.info(f"Executing on {self.target.value} node: {node}")
connection.execute(self.format_sql(), settings=self._settings)

@abstractmethod
Expand Down

0 comments on commit 94fa31a

Please sign in to comment.