Skip to content

Commit

Permalink
perf(spans): Remove transaction_id from PREWHERE for spans (#6065)
Browse files Browse the repository at this point in the history
There is no index on `transaction_id` nor is it part of the table's ORDER BY.
Because of this, promoting conditions on the `transaction_id` to the PREWHERE
clause actually slows down the query quite significantly.
  • Loading branch information
Zylphrex authored Jun 25, 2024
1 parent 553fd81 commit 9aac9d3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion snuba/datasets/configuration/spans/storages/spans.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ query_processors:
- processor: PrewhereProcessor
args:
prewhere_candidates:
[transaction_id, span_id, trace_id, segment_name]
[span_id, trace_id, segment_name]
- processor: TableRateLimit
- processor: TupleUnaliaser

Expand Down

0 comments on commit 9aac9d3

Please sign in to comment.