Add a setting for batch_join_timeout (#6314)

Closes #6306
getsentry · Sep 17, 2024 · 9b2b0ab · 9b2b0ab
1 parent 29438a7
commit 9b2b0ab
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/snuba/clickhouse/http.py b/snuba/clickhouse/http.py
@@ -353,7 +353,9 @@ def write(self, values: Iterable[bytes]) -> None:
  batch.append(value)
 
  batch.close()
- batch_join_timeout = state.get_config("http_batch_join_timeout", 10)
+ batch_join_timeout = state.get_config(
+ "http_batch_join_timeout", settings.BATCH_JOIN_TIMEOUT
+ )
  # IMPORTANT: Please read the docstring of this method if you ever decide to remove the
  # timeout argument from the join method.
  batch.join(timeout=batch_join_timeout)
diff --git a/snuba/settings/__init__.py b/snuba/settings/__init__.py
@@ -242,6 +242,7 @@ class RedisClusters(TypedDict):
 DISCARD_OLD_EVENTS = True
 CLICKHOUSE_HTTP_CHUNK_SIZE = 8192
 HTTP_WRITER_BUFFER_SIZE = 1
+BATCH_JOIN_TIMEOUT = os.environ.get("BATCH_JOIN_TIMEOUT", 10)
 
 # Retention related settings
 ENFORCE_RETENTION: bool = False