expose trace_sampled and num_processing_errors from events and discov…

…er entities (#4368)

snuba/datasets/configuration/discover/entities/discover.yaml

@@ -259,6 +259,16 @@ schema:
  type: UUID,
  args: { schema_modifiers: [nullable] },
  },
+ {
+ name: trace_sampled,
+ type: UInt,
+ args: { schema_modifiers: [ nullable ], size: 8 },
+ },
+ {
+ name: num_processing_errors,
+ type: UInt,
+ args: { schema_modifiers: [ nullable ], size: 64 },
+ },
  ]
 required_time_column: timestamp
 storages:

snuba/datasets/configuration/discover/entities/discover_events.yaml

@@ -192,6 +192,16 @@ schema:
  [{ name: name, type: String }, { name: version, type: String }],
  },
  },
+ {
+ name: trace_sampled,
+ type: UInt,
+ args: { schema_modifiers: [ nullable ], size: 8 },
+ },
+ {
+ name: num_processing_errors,
+ type: UInt,
+ args: { schema_modifiers: [ nullable ], size: 64 },
+ },
  ]
 required_time_column: timestamp
 storages:

snuba/datasets/configuration/discover/entities/discover_transactions.yaml

@@ -267,6 +267,8 @@ storages:
  - exception_main_thread
  - modules.name
  - modules.version
+ - trace_sampled
+ - num_processing_errors
  subscriptables:
  - mapper: SubscriptableMapper
  args:

snuba/datasets/configuration/events/entities/events.yaml

@@ -192,6 +192,16 @@ schema:
  [{ name: name, type: String }, { name: version, type: String }],
  },
  },
+ {
+ name: trace_sampled,
+ type: UInt,
+ args: { schema_modifiers: [ nullable ], size: 8 },
+ },
+ {
+ name: num_processing_errors,
+ type: UInt,
+ args: { schema_modifiers: [ nullable ], size: 64 },
+ },
  ]
 required_time_column: timestamp
 storages:

snuba/query/snql/discover_entity_selection.py

@@ -89,6 +89,8 @@
  ),
  ("modules", Nested([("name", String()), ("version", String())])),
  ("exception_main_thread", UInt(8, Modifiers(nullable=True))),
+ ("trace_sampled", UInt(8, Modifiers(nullable=True))),
+ ("num_processing_errors", UInt(64, Modifiers(nullable=True))),
  ]
 )
 

tests/test_discover_api.py

@@ -1736,6 +1736,29 @@ def test_tagstore_sampling(self) -> None:
  data = json.loads(response.data)["data"]
  assert len(data) == 11
 
+ def test_trace_sample_num_processing_errors(self) -> None:
+ response = self.post(
+ json.dumps(
+ {
+ "selected_columns": ["trace_sampled", "num_processing_errors"],
+ "limit": 1000,
+ "project": [self.project_id],
+ "dataset": "discover",
+ "tenant_ids": {"referrer": "r", "organization_id": 1234},
+ "from_date": (self.base_time - self.skew).isoformat(),
+ "to_date": (self.base_time + self.skew).isoformat(),
+ "conditions": [["project_id", "IN", [self.project_id]]],
+ "consistent": False,
+ }
+ ),
+ entity="discover",
+ )
+
+ assert response.status_code == 200
+ data = json.loads(response.data)["data"]
+ assert len(data) == 1
+ assert data == [{"trace_sampled": None, "num_processing_errors": 0}]
+
 
 class TestDiscoverAPIEntitySelection(TestDiscoverApi):
  """