fix(rust): Don't produce commit log in --skip-write mode (#5385)

getsentry · Jan 12, 2024 · b36448e · b36448e
1 parent 4bf9b58
commit b36448e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/rust_snuba/src/factory.rs b/rust_snuba/src/factory.rs
@@ -100,7 +100,7 @@ impl ProcessingStrategyFactory<KafkaPayload> for ConsumerStrategyFactory {
  self.physical_topic_name,
  self.physical_consumer_group.clone(),
  &self.commitlog_concurrency,
- false,
+ self.skip_write,
  ))
  } else {
  Box::new(next_step)

diff --git a/rust_snuba/src/strategies/commit_log.rs b/rust_snuba/src/strategies/commit_log.rs
@@ -167,7 +167,6 @@ pub struct ProduceCommitLog {
 }
 
 impl ProduceCommitLog {
- #[allow(dead_code)]
  pub fn new<N>(
  next_step: N,
  producer: Arc<dyn Producer<KafkaPayload> + 'static>,