Skip to content

Commit

Permalink
Cleanup some settings from settings_test.py (#6313)
Browse files Browse the repository at this point in the history
During the investigation of
#6279, I found that:
- `OPTIMIZE_JOB_CUTOFF_TIME` is overridden to `24` and it was causing
test failures.
- `OPTIMIZE_PARALLEL_MAX_JITTER_MINUTES` does not seem to be used
anywhere in the code.

With the change, less no. of local tests fail. The failure number is
non-zero because #6279 was
reverted yesterday . I would like to verify if this small change passes
through the CI and stays stable in prod.
  • Loading branch information
onkar authored Sep 17, 2024
1 parent 6b5efd6 commit e113f91
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions snuba/settings/settings_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,6 @@
# Set enforce retention to true for tests
ENFORCE_RETENTION = True

# Ignore optimize job cut off time for tests
OPTIMIZE_JOB_CUTOFF_TIME = 24

OPTIMIZE_PARALLEL_MAX_JITTER_MINUTES = 0

ADMIN_ALLOWED_PROD_PROJECTS = [1, 11276]

REDIS_CLUSTERS = {
Expand Down

0 comments on commit e113f91

Please sign in to comment.