Skip to content

Commit

Permalink
Remove metric_mri as required column since the validator required the…
Browse files Browse the repository at this point in the history
… column type to be an integer
  • Loading branch information
phacops committed Dec 8, 2023
1 parent ce3e1eb commit f889ec8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ validators:
args:
required_filter_columns:
- project_id
- metric_mri
- validator: TagConditionValidator
args: {}
- validator: DatetimeConditionValidator
Expand Down
2 changes: 1 addition & 1 deletion snuba/query/validation/validators.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def validate(self, query: Query, alias: Optional[str] = None) -> None:
if self.required_columns:
for col in self.required_columns:
match = build_match(
col=col, ops=[ConditionFunctions.EQ], param_type=int, alias=alias
col=col, ops=[ConditionFunctions.EQ], param_type=None, alias=alias
)
found = any(match.match(cond) for cond in top_level)
if not found:
Expand Down

0 comments on commit f889ec8

Please sign in to comment.