feat(replays): Add click_is_dead and click_is_rage columns (#4470)

* Add is_dead and is_rage columns * Safely extract keys * Revert "Safely extract keys" This reverts commit eeeea85.
getsentry · Jul 14, 2023 · fe6e66c · fe6e66c
1 parent 1df9407
commit fe6e66c
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 0 deletions.
diff --git a/snuba/datasets/configuration/replays/entities/replays.yaml b/snuba/datasets/configuration/replays/entities/replays.yaml
@@ -101,6 +101,8 @@ schema:
  { name: click_testid, type: String, args: {} },
  { name: click_aria_label, type: String, args: {} },
  { name: click_title, type: String, args: {} },
+ { name: click_is_dead, type: UInt, args: { size: 8 } },
+ { name: click_is_rage, type: UInt, args: { size: 8 } },
  { name: retention_days, type: UInt, args: { size: 16 } },
  { name: partition, type: UInt, args: { size: 16 } },
  { name: offset, type: UInt, args: { size: 64 } },

diff --git a/snuba/datasets/configuration/replays/storages/replays.yaml b/snuba/datasets/configuration/replays/storages/replays.yaml
@@ -150,6 +150,8 @@ schema:
  { name: click_testid, type: String, args: {} },
  { name: click_aria_label, type: String, args: {} },
  { name: click_title, type: String, args: {} },
+ { name: click_is_dead, type: UInt, args: { size: 8 } },
+ { name: click_is_rage, type: UInt, args: { size: 8 } },
  { name: retention_days, type: UInt, args: { size: 16 } },
  { name: partition, type: UInt, args: { size: 16 } },
  { name: offset, type: UInt, args: { size: 64 } },

diff --git a/snuba/datasets/processors/replays_processor.py b/snuba/datasets/processors/replays_processor.py
@@ -251,6 +251,8 @@ def process_replay_actions(
  "click_testid": to_string(click["testid"])[:64],
  "click_aria_label": to_string(click["aria_label"])[:64],
  "click_title": to_string(click["title"])[:64],
+ "click_is_dead": to_uint1(click["is_dead"]),
+ "click_is_rage": to_uint1(click["is_rage"]),
  }
  for click in payload["clicks"][:MAX_CLICK_EVENTS]
  ]
@@ -294,6 +296,14 @@ def to_datetime(value: Any) -> datetime:
  return _timestamp_to_datetime(_collapse_or_err(_collapse_uint32, int(value)))
 
 
+def to_uint1(value: Any) -> int:
+ int_value = int(value)
+ if int_value == 0 or int_value == 1:
+ return int_value
+ else:
+ raise ValueError("Value must be 0 or 1")
+
+
 def to_uint16(value: Any) -> int:
  return _collapse_or_err(_collapse_uint16, int(value))
 

diff --git a/tests/datasets/test_replays_processor.py b/tests/datasets/test_replays_processor.py
@@ -707,6 +707,8 @@ def test_replay_actions(self) -> None:
  "text": "text",
  "timestamp": int(now.timestamp()),
  "event_hash": "df3c3aa2daae465e89f1169e49139827",
+ "is_dead": 0,
+ "is_rage": 1,
  }
  ],
  }
@@ -746,3 +748,5 @@ def test_replay_actions(self) -> None:
  assert row["click_alt"] == ""
  assert row["click_testid"] == ""
  assert row["click_title"] == ""
+ assert row["click_is_dead"] == 0
+ assert row["click_is_rage"] == 1