feat(rust): add some metrics backends #4063
Conversation
dbanda
force-pushed
the
dbanda/rust/add_metrics
branch
from
05125cf
to
cb0a843
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #4063 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 803 803
Lines 39514 39514
Branches 245 245
=======================================
Hits 35698 35698
Misses 3784 3784
Partials 32 32 ☔ View full report in Codecov by Sentry. |
dbanda
force-pushed
the
dbanda/rust/add_metrics
branch
2 times, most recently
from
118a232
to
506ca85
Compare
| for _ in 0..v.abs() { | ||
| if v < 0 { | ||
| self.client_sd.decr(key, &tags_str).unwrap(); | ||
| } else { | ||
| self.client_sd.incr(key, &tags_str).unwrap(); | ||
| } | ||
| } |
There was a problem hiding this comment.
should this logic be replaced by https://docs.rs/dogstatsd/latest/dogstatsd/struct.Client.html#method.count ?
Seems inefficient to send n decr messages vs. subtract n if that's possible
There was a problem hiding this comment.
Yeah that was so dumb. Updated.
dbanda
force-pushed
the
dbanda/rust/add_metrics
branch
from
2ff48c4
to
e04575f
Compare
| @@ -8,7 +8,12 @@ use std::collections::HashMap; | |||
| use std::net::{ToSocketAddrs, UdpSocket}; | |||
| use std::sync::Arc; | |||
|
|
|||
| pub trait Metrics { | |||
| pub trait MetricsClientTrait: Send + Sync { | |||
There was a problem hiding this comment.
it's not idiomatic to name traits as Trait
Switches the metrics client to be a trait and introduces a testing and datadog backend of the metrics client. Datadog is still WIP but this impl uses the dogstatsd library.