Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schemas): Validate all source topics have schemas defined #4374

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

lynnagara
Copy link
Member

There's a few temporary exclusions for schemas which still need to be created.

There's a few temporary exclusions for schemas which still need to be created.
@lynnagara lynnagara requested a review from a team as a code owner June 17, 2023 01:30
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Patch coverage: 95.65% and no project coverage change.

Comparison is base (20076d2) 90.72% compared to head (6ca0768) 90.72%.

❗ Current head 6ca0768 differs from pull request most recent head 4f13a3f. Consider uploading reports for the commit 4f13a3f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4374   +/-   ##
=======================================
  Coverage   90.72%   90.72%           
=======================================
  Files         797      797           
  Lines       39175    39187   +12     
  Branches      245      245           
=======================================
+ Hits        35540    35551   +11     
- Misses       3603     3604    +1     
  Partials       32       32           
Impacted Files Coverage Δ
tests/consumers/test_schemas.py 96.15% <90.90%> (-1.41%) ⬇️
snuba/admin/dead_letter_queue/__init__.py 96.77% <100.00%> (-0.73%) ⬇️
snuba/datasets/storages/factory.py 97.10% <100.00%> (+0.49%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lynnagara lynnagara merged commit 4a3c547 into master Jun 20, 2023
12 checks passed
@lynnagara lynnagara deleted the validate-topic-schema branch June 20, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants