Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for customer deployments #4438

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

mattgauntseo-sentry
Copy link
Contributor

I noticed that s4s has slightly differently migration steps for s4s and ST deployments.

This PR moves the container name / service name to an environment variable so we can re-use the migrate-reverse script on all regions and then there is a second script for the ST deployments migration.

Hopefully in the future we can merge the migration scripts, but this is the safest approach to avoid breaking things for now.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.08 ⚠️

Comparison is base (ce7bc50) 92.43% compared to head (906ed41) 90.35%.

❗ Current head 906ed41 differs from pull request most recent head 0f12c18. Consider uploading reports for the commit 0f12c18 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4438      +/-   ##
==========================================
- Coverage   92.43%   90.35%   -2.08%     
==========================================
  Files         769      804      +35     
  Lines       38218    39568    +1350     
  Branches        0      245     +245     
==========================================
+ Hits        35326    35751     +425     
- Misses       2892     3785     +893     
- Partials        0       32      +32     

see 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mattgauntseo-sentry mattgauntseo-sentry merged commit 48ac90c into master Jul 5, 2023
21 checks passed
@mattgauntseo-sentry mattgauntseo-sentry deleted the mgs-st-differences branch July 5, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants