Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dlq): Record DLQ replay to audit log #4439

Merged
merged 1 commit into from
Jul 5, 2023
Merged

feat(dlq): Record DLQ replay to audit log #4439

merged 1 commit into from
Jul 5, 2023

Conversation

lynnagara
Copy link
Member

No description provided.

@lynnagara lynnagara requested a review from a team as a code owner June 29, 2023 00:52
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -2.09 ⚠️

Comparison is base (ce7bc50) 92.43% compared to head (a38e530) 90.34%.

❗ Current head a38e530 differs from pull request most recent head fd20511. Consider uploading reports for the commit fd20511 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4439      +/-   ##
==========================================
- Coverage   92.43%   90.34%   -2.09%     
==========================================
  Files         769      804      +35     
  Lines       38218    39571    +1353     
  Branches        0      245     +245     
==========================================
+ Hits        35326    35752     +426     
- Misses       2892     3787     +895     
- Partials        0       32      +32     
Impacted Files Coverage Δ
snuba/admin/views.py 70.73% <0.00%> (-0.32%) ⬇️
snuba/admin/audit_log/action.py 100.00% <100.00%> (ø)

... and 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lynnagara lynnagara changed the title feat(dlq): If DLQ replay is kicked off, add it to audit log feat(dlq): Record DLQ replay to audit log Jun 29, 2023
@lynnagara lynnagara merged commit c161ca5 into master Jul 5, 2023
21 checks passed
@lynnagara lynnagara deleted the dlq-auditlog branch July 5, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants