Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spans): Add group_raw to HexIntColumnProcessor #4459

Merged

Conversation

shruthilayaj
Copy link
Member

@shruthilayaj shruthilayaj commented Jul 4, 2023

Add group_raw to the HexIntColumnProcessor because
right now we return the raw int and we'd like to return
the hash instead as we do with group

@shruthilayaj shruthilayaj marked this pull request as ready for review July 4, 2023 16:53
@shruthilayaj shruthilayaj requested a review from a team as a code owner July 4, 2023 16:53
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -2.23 ⚠️

Comparison is base (e670cda) 92.76% compared to head (f92d172) 90.54%.

❗ Current head f92d172 differs from pull request most recent head 7667044. Consider uploading reports for the commit 7667044 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4459      +/-   ##
==========================================
- Coverage   92.76%   90.54%   -2.23%     
==========================================
  Files         768      806      +38     
  Lines       38272    39768    +1496     
  Branches        0      258     +258     
==========================================
+ Hits        35504    36007     +503     
- Misses       2768     3727     +959     
- Partials        0       34      +34     
Impacted Files Coverage Δ
tests/test_spans_api.py 100.00% <100.00%> (ø)

... and 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shruthilayaj shruthilayaj merged commit 9d7a21b into master Jul 4, 2023
@shruthilayaj shruthilayaj deleted the shruthi/fix/add-hex-processor-to-span-group-raw branch July 4, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants