Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "feat: Experiment using statsdproxy for aggregation (#… #5064

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

lynnagara
Copy link
Member

@lynnagara lynnagara commented Nov 17, 2023

…4734)""

I reverted the original PR was reverted since it seems to cause a 6x reduction in throughput. Re-opening in case we want to try it again.

This reverts commit 201e07b.

@lynnagara lynnagara requested a review from a team as a code owner November 17, 2023 23:09
@lynnagara lynnagara requested a review from a team November 17, 2023 23:09
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (257e690) 90.52% compared to head (de4ca37) 90.52%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5064   +/-   ##
=======================================
  Coverage   90.52%   90.52%           
=======================================
  Files         880      880           
  Lines       43071    43071           
  Branches      288      288           
=======================================
  Hits        38992    38992           
  Misses       4037     4037           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lynnagara lynnagara marked this pull request as draft November 18, 2023 00:47
@untitaker
Copy link
Member

I think it's just this mutex causing trouble, and we'd probably be able to fix this by making the entire metrics client thread-local: https://github.com/getsentry/statsdproxy/blob/07b51e05107882226d94c27207bb968c1181e3d9/src/cadence.rs#L38

@untitaker untitaker marked this pull request as ready for review January 2, 2024 12:33
@untitaker
Copy link
Member

getsentry/statsdproxy#38

@untitaker untitaker merged commit 92eefab into master Jan 2, 2024
32 checks passed
@untitaker untitaker deleted the unrevert-statsdproxy branch January 2, 2024 14:09
@getsentry-bot
Copy link
Contributor

PR reverted: b291670

getsentry-bot added a commit that referenced this pull request Jan 2, 2024
…ation (#… (#5064)"

This reverts commit 92eefab.

Co-authored-by: untitaker <837573+untitaker@users.noreply.github.com>
untitaker added a commit that referenced this pull request Jan 2, 2024
untitaker added a commit that referenced this pull request Jan 2, 2024
* Revert "Revert "Revert "Revert "feat: Experiment using statsdproxy for aggregation (#… (#5064)""

This reverts commit b291670.

* ref(rust): update statsdproxy

remove dbg!() statement that slows down the entire rust consumer

* fix benchmark

* fmt

* reorder import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants