-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "feat: Experiment using statsdproxy for aggregation (#… #5064
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5064 +/- ##
=======================================
Coverage 90.52% 90.52%
=======================================
Files 880 880
Lines 43071 43071
Branches 288 288
=======================================
Hits 38992 38992
Misses 4037 4037
Partials 42 42 ☔ View full report in Codecov by Sentry. |
I think it's just this mutex causing trouble, and we'd probably be able to fix this by making the entire metrics client thread-local: https://github.com/getsentry/statsdproxy/blob/07b51e05107882226d94c27207bb968c1181e3d9/src/cadence.rs#L38 |
PR reverted: b291670 |
…4734)""
I reverted the original PR was reverted since it seems to cause a 6x reduction in throughput. Re-opening in case we want to try it again.
This reverts commit 201e07b.