Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Arroyo 2.15.0 and reusable multiprocessing pools #5170

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

lynnagara
Copy link
Member

Contains perf improvements for rebalancing

@lynnagara lynnagara marked this pull request as ready for review December 6, 2023 23:42
@lynnagara lynnagara requested a review from a team as a code owner December 6, 2023 23:42
@lynnagara lynnagara changed the title ref: Arroyo 2.15.0 ref: Arroyo 2.15.0 and reusable multiprocessing pools Dec 6, 2023
@lynnagara lynnagara changed the title ref: Arroyo 2.15.0 and reusable multiprocessing pools perf: Arroyo 2.15.0 and reusable multiprocessing pools Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (38d04d6) 90.68% compared to head (a83e5e2) 90.64%.
Report is 2 commits behind head on master.

Files Patch % Lines
snuba/consumers/consumer.py 66.66% 2 Missing ⚠️
snuba/consumers/strategy_factory.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5170      +/-   ##
==========================================
- Coverage   90.68%   90.64%   -0.05%     
==========================================
  Files         862      862              
  Lines       42061    42072      +11     
  Branches      288      288              
==========================================
- Hits        38144    38137       -7     
- Misses       3875     3893      +18     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lynnagara lynnagara enabled auto-merge (squash) December 7, 2023 19:35
@lynnagara lynnagara merged commit 3600abf into master Dec 7, 2023
31 of 32 checks passed
@lynnagara lynnagara deleted the arroyo-2.15.0 branch December 7, 2023 19:50
Copy link

sentry-io bot commented Dec 7, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ FileNotFoundError: [Errno 2] No such file or directory: '/psm_9ae1776a' [cli init] consumer View Issue
  • ‼️ FileNotFoundError: [Errno 2] No such file or directory: '/psm_c7d456d8' [cli init] consumer View Issue

Did you find this useful? React with a 👍 or 👎

@getsentry-bot
Copy link
Contributor

PR reverted: 1950498

getsentry-bot added a commit that referenced this pull request Dec 7, 2023
This reverts commit 3600abf.

Co-authored-by: lynnagara <1779792+lynnagara@users.noreply.github.com>
lynnagara added a commit that referenced this pull request Dec 7, 2023
lynnagara added a commit that referenced this pull request Dec 8, 2023
Try #5170 again with a high join timeout.

This PR is a short term test that should be reverted. We want to check if there's any correlation between join timeout and the consumer issues we saw with arroyo 2.15.0 earlier.
lynnagara added a commit that referenced this pull request Dec 11, 2023
lynnagara added a commit that referenced this pull request Dec 11, 2023
Retry #5170, this time with some fixes to Arroyo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants