Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(rust): Do not do extra work when merging if not needed #5294

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Jan 3, 2024

No description provided.

@phacops phacops marked this pull request as ready for review January 3, 2024 19:25
@phacops phacops requested a review from a team as a code owner January 3, 2024 19:25
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b211283) 90.50% compared to head (c217fe5) 90.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5294      +/-   ##
==========================================
- Coverage   90.50%   90.49%   -0.01%     
==========================================
  Files         880      880              
  Lines       43082    43082              
  Branches      288      288              
==========================================
- Hits        38990    38987       -3     
- Misses       4050     4053       +3     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phacops phacops merged commit 0409b3f into master Jan 4, 2024
32 checks passed
@phacops phacops deleted the pierre/rust-do-not-merge-batch-if-not-needed branch January 4, 2024 15:40
@getsentry-bot
Copy link
Contributor

PR reverted: 5ce9183

@untitaker
Copy link
Member

Reverting because of SNUBA-441

getsentry-bot added a commit that referenced this pull request Jan 4, 2024
…5294)"

This reverts commit 0409b3f.

Co-authored-by: untitaker <837573+untitaker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants