Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(rust): Remove Python processors in favor of Rust ones #5345

Merged
merged 22 commits into from
Jan 9, 2024

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Jan 9, 2024

This omit the functions processor as it was causing issues with some tests.

@phacops phacops requested a review from a team as a code owner January 9, 2024 13:34
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (dd479de) 93.10% compared to head (51d9f87) 90.66%.

Files Patch % Lines
tests/datasets/test_spans_payloads.py 83.33% 1 Missing ⚠️
tests/datasets/test_spans_processor.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5345      +/-   ##
==========================================
- Coverage   93.10%   90.66%   -2.44%     
==========================================
  Files         840      878      +38     
  Lines       41373    42727    +1354     
  Branches        0      288     +288     
==========================================
+ Hits        38519    38739     +220     
- Misses       2854     3946    +1092     
- Partials        0       42      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phacops phacops merged commit c9cbb24 into master Jan 9, 2024
33 checks passed
@phacops phacops deleted the pierre/cleanup-python-processors-2 branch January 9, 2024 14:12
@getsentry-bot
Copy link
Contributor

PR reverted: f25f8e8

getsentry-bot added a commit that referenced this pull request Jan 9, 2024
)"

This reverts commit c9cbb24.

Co-authored-by: lynnagara <1779792+lynnagara@users.noreply.github.com>
@lynnagara
Copy link
Member

This was breaking sentry CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants