Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spans): Set origin_timestamp for spans #5367

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Jan 10, 2024

We're now setting a received field for a span message: https://github.com/getsentry/relay/blob/master/relay-server/src/actors/store.rs#L1168

@phacops phacops requested a review from a team as a code owner January 10, 2024 16:26
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d07e32) 90.70% compared to head (3599268) 90.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5367   +/-   ##
=======================================
  Coverage   90.70%   90.70%           
=======================================
  Files         881      881           
  Lines       42818    42818           
  Branches      288      288           
=======================================
  Hits        38840    38840           
  Misses       3936     3936           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phacops phacops merged commit 0fa6894 into master Jan 10, 2024
32 checks passed
@phacops phacops deleted the pierre/spans-set-origin_timestamp branch January 10, 2024 17:36
@untitaker
Copy link
Member

this made received required, so it broke sentry

@getsentry-bot
Copy link
Contributor

PR reverted: 1c963c3

getsentry-bot added a commit that referenced this pull request Jan 10, 2024
This reverts commit 0fa6894.

Co-authored-by: untitaker <837573+untitaker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants