feat(rust): Add a metric for invalid schema validations #5515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phacops
force-pushed
the
pierre/rust-metrics-in-snuba
branch
from
8823afc
to
5bfa030
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5515 +/- ##
=======================================
Coverage 90.04% 90.04%
=======================================
Files 892 892
Lines 43288 43288
Branches 288 288
=======================================
Hits 38979 38979
Misses 4267 4267
Partials 42 42 ☔ View full report in Codecov by Sentry. |
untitaker
approved these changes
Feb 9, 2024
|
I'm reverting this because it seems that we already record this metric in |
|
PR reverted: b597627 |
getsentry-bot
added a commit
that referenced
this pull request
Feb 15, 2024
This reverts commit 3f38e42. Co-authored-by: untitaker <837573+untitaker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.