feat: Remove query splitters from the API #5571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After testing how much the splitters were being used, and the improvement they were providing, splitters were only being used on a very small percentage of queries (up to 5% on the highest dataset). After pausing the splitters, there was almost no impact on the performance of queries. Only a single referrer had a noticeable performance degradation, and that was not enough to cause any actual impact on the queries (rate limiting, timeouts etc.)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5571 +/- ##
==========================================
- Coverage 89.90% 89.88% -0.03%
==========================================
Files 896 893 -3
Lines 43418 43179 -239
Branches 288 288
==========================================
- Hits 39034 38810 -224
+ Misses 4342 4327 -15
Partials 42 42 ☔ View full report in Codecov by Sentry. |
enochtangg
approved these changes
Feb 21, 2024
|
PR reverted: ab239e8 |
getsentry-bot
added a commit
that referenced
this pull request
Feb 22, 2024
This reverts commit 01af478. Co-authored-by: asottile-sentry <103459774+asottile-sentry@users.noreply.github.com>
|
this is breaking sentry: |
evanh
added a commit
to getsentry/sentry
that referenced
this pull request
Mar 14, 2024
This one test fails in Snuba CI, however I have been completely unable to reproduce this failure in any other environment. That includes prod, because the change that breaks this (removing query splitters in Snuba) is currently running in prod. It is also extremely difficult to debug this problem using just CI. So, this test will be xfail'd for now, then after the Snuba change is merged in, I can debug this test in a much easier way. Snuba change in question: getsentry/snuba#5571
evanh
added a commit
that referenced
this pull request
Mar 15, 2024
* Original commit: "feat: Remove query splitters from the API (#5571)" After testing how much the splitters were being used, and the improvement they were providing, splitters were only being used on a very small percentage of queries (up to 5% on the highest dataset). After pausing the splitters, there was almost no impact on the performance of queries. Only a single referrer had a noticeable performance degradation, and that was not enough to cause any actual impact on the queries (rate limiting, timeouts etc.) * Unrevert: feat: Remove query splitters from the API This was reverted because it was causing a test failure in Sentry master.
JonasBa
pushed a commit
to getsentry/sentry
that referenced
this pull request
Mar 17, 2024
This one test fails in Snuba CI, however I have been completely unable to reproduce this failure in any other environment. That includes prod, because the change that breaks this (removing query splitters in Snuba) is currently running in prod. It is also extremely difficult to debug this problem using just CI. So, this test will be xfail'd for now, then after the Snuba change is merged in, I can debug this test in a much easier way. Snuba change in question: getsentry/snuba#5571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing how much the splitters were being used, and the improvement they
were providing, splitters were only being used on a very small percentage
of queries (up to 5% on the highest dataset). After pausing the splitters,
there was almost no impact on the performance of queries. Only a single
referrer had a noticeable performance degradation, and that was not enough to
cause any actual impact on the queries (rate limiting, timeouts etc.)