Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match ops labels #5678

Merged
merged 4 commits into from
Mar 21, 2024
Merged

match ops labels #5678

merged 4 commits into from
Mar 21, 2024

Conversation

dbanda
Copy link
Contributor

@dbanda dbanda commented Mar 21, 2024

This changes the replayer, fetcher and comparison gocd pipelines to use labels that are consistent with the OPs repo i.e the service name is snuba for all but they have different component labels. This make it easier to write deployment scripts.

relevant ops PR: https://github.com/getsentry/ops/pull/9783

@dbanda dbanda marked this pull request as ready for review March 21, 2024 19:55
@dbanda dbanda requested a review from a team as a code owner March 21, 2024 19:55
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (f66a9fa) to head (226c29a).

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5678      +/-   ##
==========================================
- Coverage   89.91%   89.87%   -0.04%     
==========================================
  Files         894      894              
  Lines       43393    43393              
  Branches      299      299              
==========================================
- Hits        39017    39001      -16     
- Misses       4334     4350      +16     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbanda dbanda enabled auto-merge (squash) March 21, 2024 20:25
@dbanda dbanda merged commit bbaa4a0 into master Mar 21, 2024
32 checks passed
@dbanda dbanda deleted the dbanda/replayer-match-ops-labels branch March 21, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants