feat(mapping-optimizer): Support in operator for mapping optimizer #5691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-apply #5685 This was a TODO item. But on the spans dataset, one easy to encounter situation is a condition like ``` sentry_tags[key] IN (value1, value2) ``` This results in a sql like ``` in((arrayElement(sentry_tags.value, indexOf(sentry_tags.key, 'key')) AS `_snuba_sentry_tags[key]`), ['value1', 'value1']) ``` which scans the entire `sentry_tags.key` and `sentry_tags.value` columns. The optimization here is to use the tags hash map which gives us a condition like ``` hasAny(_sentry_tags_hash_map, array(cityHash64('key=value1'), cityHash64('key=value1'))) ```
Zylphrex
commented
Mar 26, 2024
| @@ -366,6 +366,7 @@ jobs: | |||
| tests/sentry/search/events \ | |||
| tests/sentry/event_manager \ | |||
| tests/sentry/api/endpoints/test_organization_profiling_functions.py \ | |||
| tests/snuba/api/endpoints/test_organization_events_stats_mep.py \ | |||
There was a problem hiding this comment.
A test in here was failing in the last attempt
Comment on lines
+202
to
+204
| # tags[foo] IN array('') is not optimizable | ||
| if param.value == "": | ||
| return ConditionClass.NOT_OPTIMIZABLE |
There was a problem hiding this comment.
This was the cause of the test failure. Due to the way we query for tags, even if foo is not a tag on the row, it has a value of '' and won't exist in the tags hash map.
To handle this, we just mark these cases are not optimizable. and run the query as is.
| ( | ||
| Literal(None, "a"), | ||
| Literal(None, "b"), | ||
| Literal(None, ""), |
There was a problem hiding this comment.
new test with an empty value in the list to capture this failure case
volokluev
approved these changes
Mar 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## master #5691 +/- ##
==========================================
- Coverage 92.17% 89.82% -2.36%
==========================================
Files 859 900 +41
Lines 42080 43770 +1690
Branches 0 301 +301
==========================================
+ Hits 38788 39317 +529
- Misses 3292 4411 +1119
- Partials 0 42 +42 ☔ View full report in Codecov by Sentry. |
Zylphrex
deleted the
txiao/feat/support-in-operator-for-mapping-optimizers-2
branch
|
PR reverted: 7ed7441 |
Zylphrex
added a commit
that referenced
this pull request
Mar 26, 2024
…5691) Re-apply #5685 This was a TODO item. But on the spans dataset, one easy to encounter situation is a condition like ``` sentry_tags[key] IN (value1, value2) ``` This results in a sql like ``` in((arrayElement(sentry_tags.value, indexOf(sentry_tags.key, 'key')) AS `_snuba_sentry_tags[key]`), ['value1', 'value1']) ``` which scans the entire `sentry_tags.key` and `sentry_tags.value` columns. The optimization here is to use the tags hash map which gives us a condition like ``` hasAny(_sentry_tags_hash_map, array(cityHash64('key=value1'), cityHash64('key=value1'))) ```
Zylphrex
added a commit
that referenced
this pull request
Mar 27, 2024
…5691) (#5692) Re-apply #5685 This was a TODO item. But on the spans dataset, one easy to encounter situation is a condition like ``` sentry_tags[key] IN (value1, value2) ``` This results in a sql like ``` in((arrayElement(sentry_tags.value, indexOf(sentry_tags.key, 'key')) AS `_snuba_sentry_tags[key]`), ['value1', 'value1']) ``` which scans the entire `sentry_tags.key` and `sentry_tags.value` columns. The optimization here is to use the tags hash map which gives us a condition like ``` hasAny(_sentry_tags_hash_map, array(cityHash64('key=value1'), cityHash64('key=value1'))) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-apply #5685
This was a TODO item. But on the spans dataset, one easy to encounter situation is a condition like
This results in a sql like
which scans the entire
sentry_tags.keyandsentry_tags.valuecolumns. The optimization here is to use the tags hash map which gives us a condition like