feat(replays): add replay_id column to merged discover table #5777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has a migration; here is the generated SQL -- start migrations
-- forward migration discover : 0008_discover_add_replay_id
Local op: ALTER TABLE discover_local ADD COLUMN IF NOT EXISTS replay_id Nullable(UUID) AFTER span_id;
Distributed op: ALTER TABLE discover_dist ADD COLUMN IF NOT EXISTS replay_id Nullable(UUID) AFTER span_id;
-- end forward migration discover : 0008_discover_add_replay_id
-- backward migration discover : 0008_discover_add_replay_id
Distributed op: ALTER TABLE discover_dist DROP COLUMN IF EXISTS replay_id;
Local op: ALTER TABLE discover_local DROP COLUMN IF EXISTS replay_id;
-- end backward migration discover : 0008_discover_add_replay_id |
|
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 1104 tests with View the full list of failed tests
|
volokluev
approved these changes
Apr 16, 2024
|
PR reverted: 2f1509f |
JoshFerge
added a commit
to getsentry/sentry
that referenced
this pull request
Apr 22, 2024
We want to have the replay_id column be queried on instead of the tag that we previously had, as we no longer are populating the tag for non javascript platforms. Depends on getsentry/snuba#5777.
MichaelSun48
pushed a commit
to getsentry/sentry
that referenced
this pull request
Apr 25, 2024
We want to have the replay_id column be queried on instead of the tag that we previously had, as we no longer are populating the tag for non javascript platforms. Depends on getsentry/snuba#5777.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we want to be able to query this field in discover. it exists on both errors and transactions.