Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(devexp): remove dead code #5793

Merged
merged 9 commits into from
Apr 22, 2024
Merged

feat(devexp): remove dead code #5793

merged 9 commits into from
Apr 22, 2024

Conversation

volokluev
Copy link
Member

  • Remove pipeline delegator (no longer useful with new pipeline, not called anywhere)
  • Remove dataset query pipeline builder (not called anywher)
  • Remove anonymized snql code (we don't use the output)

@volokluev volokluev requested a review from a team as a code owner April 17, 2024 20:54
@codecov Codecov
Copy link

codecov bot commented Apr 17, 2024 •
edited
Loading

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 1621 tests with 1 failed, 1618 passed and 2 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
pytest

Test name:
tests.query.parser.test_formula_mql_query::test_simple_formula

Envs:
- default
 
Traceback (most recent call last):
  File ".../query/parser/test_formula_mql_query.py", line 304, in test_simple_formula
    query, _ = parse_mql_query(str(query_body), mql_context, generic_metrics)
    ^^^^^^^^
TypeError: cannot unpack non-iterable Query object

@volokluev volokluev merged commit 300e20c into master Apr 22, 2024
30 checks passed
@volokluev volokluev deleted the volo/devexp/dead_code branch April 22, 2024 22:41
@getsentry-bot
Copy link
Contributor

PR reverted: 884c757

getsentry-bot added a commit that referenced this pull request Apr 22, 2024
@getsentry-bot @volokluev
Revert "feat(devexp): remove dead code (#5793)"
884c757 
This reverts commit 300e20c.

Co-authored-by: volokluev <3169433+volokluev@users.noreply.github.com>
volokluev added a commit that referenced this pull request Apr 30, 2024
@volokluev
Revert "Revert "feat(devexp): remove dead code (#5793)""
3fa52c9 
This reverts commit 884c757.
@volokluev volokluev mentioned this pull request Apr 30, 2024
Merged
volokluev added a commit that referenced this pull request Apr 30, 2024
@volokluev
chore(devexp): cleanup dead code (again) (#5836)
cd42255 
When I merged #5793 it conflicted with the new tests which were added and caused mypy issues. We should be able to merge this now



* Revert "Revert "feat(devexp): remove dead code (#5793)""

This reverts commit 884c757.

* fix mypy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanh evanh evanh approved these changes

@enochtangg enochtangg enochtangg approved these changes

Assignees
No one assigned
Labels
Trigger: Revert
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@volokluev @getsentry-bot @evanh @enochtangg