-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(group-attributes): Modify the column type for group_first_release_id
to bigint
#6040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snigdhas
force-pushed
the
snigdha/fix-column-type-for-group-release
branch
from
June 18, 2024 21:01
8c0979e
to
9ca11b6
Compare
This PR has a migration; here is the generated SQL -- start migrations
-- forward migration group_attributes : 0004_fix_group_first_release_id_type
Local op: ALTER TABLE group_attributes_local MODIFY COLUMN group_first_release_id Nullable(UInt64);
Distributed op: ALTER TABLE group_attributes_dist MODIFY COLUMN group_first_release_id Nullable(UInt64);
-- end forward migration group_attributes : 0004_fix_group_first_release_id_type
-- backward migration group_attributes : 0004_fix_group_first_release_id_type
Distributed op: ALTER TABLE group_attributes_dist MODIFY COLUMN group_first_release_id Nullable(UUID);
Local op: ALTER TABLE group_attributes_local MODIFY COLUMN group_first_release_id Nullable(UUID);
-- end backward migration group_attributes : 0004_fix_group_first_release_id_type |
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 1192 tests with View the full list of failed tests
|
evanh
approved these changes
Jun 20, 2024
I think the test is failing because the other PR needs to be merged first. Try running it again after the other PR is merged. |
PR reverted: 0618522 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
group_first_release_id
column was added to GroupAttributes as UUID but release IDs are bigints. The processor and YAML changes must be reverted first in #6039 so we can safely update the column type here. The column is not yet in use and has no data.Will get tests passing once the revert is in.