fix(group-attributes): Drop group_first_release_id column #6048
Conversation
|
Can you double check that #6039 was rolled out everywhere? Thanks! |
| table_name="group_attributes_dist", | ||
| column=Column( | ||
| "group_first_release_id", | ||
| UUID(Modifiers(nullable=True)), |
There was a problem hiding this comment.
Just checking here. Would UUID be the desired column type for the reverse operation (i.e. adding back the new column)? Or is UInt64 the correct type?
There was a problem hiding this comment.
It sounds like the type change didn't work? so I assumed it wasn't safe to rollback to that
There was a problem hiding this comment.
Ok, we can rollback to UUID. I suppose when we add back the column, we'll add it with the Uint64 type?
Changes were rolled out in this deploy |
|
This PR has a migration; here is the generated SQL -- start migrations
-- forward migration group_attributes : 0004_drop_first_release_id_from_group_attributes
Distributed op: ALTER TABLE group_attributes_dist DROP COLUMN IF EXISTS group_first_release_id;
Local op: ALTER TABLE group_attributes_local DROP COLUMN IF EXISTS group_first_release_id;
-- end forward migration group_attributes : 0004_drop_first_release_id_from_group_attributes
-- backward migration group_attributes : 0004_drop_first_release_id_from_group_attributes
Local op: ALTER TABLE group_attributes_local ADD COLUMN IF NOT EXISTS group_first_release_id Nullable(UUID) AFTER group_priority;
Distributed op: ALTER TABLE group_attributes_dist ADD COLUMN IF NOT EXISTS group_first_release_id Nullable(UUID) AFTER group_priority;
-- end backward migration group_attributes : 0004_drop_first_release_id_from_group_attributes |
|
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 1 tests with View the full list of failed testspytest
|
|
PR reverted: 44717a3 |
)" This reverts commit 6e377fa. Co-authored-by: evanh <2727124+evanh@users.noreply.github.com>
)" This reverts commit 6e377fa. Co-authored-by: evanh <2727124+evanh@users.noreply.github.com>
Dropping this column because the type is wrong. Previous PR to change the column type failed and had to be reverted.