-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add processor for new spans schema #6123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing tests but largely looks fine to me.
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 415 tests with View the full list of failed testspytest
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i assume storage is already merged
for the test failures, run |
PR reverted: d60b3e6 |
This reverts commit 794fec5. Co-authored-by: colin-sentry <161344340+colin-sentry@users.noreply.github.com>
We are working on a new schema for spans, to better handle arbitrary keys (hashing), improve the sort key, etc.
This listens to the same kafka topic as the existing consumer, but puts data into the new schema.