feat(profiling): Write thread id to transactions table #6138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to the profiler id, sometimes, we need the thread id to be able to link to the right thread within the profile.
nikhars
reviewed
Jul 24, 2024
nikhars
approved these changes
Jul 24, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
|
PR reverted: b604242 |
getsentry-bot
added a commit
that referenced
this pull request
Jul 25, 2024
This reverts commit a838cb6. Co-authored-by: Zylphrex <10239353+Zylphrex@users.noreply.github.com>
Zylphrex
added a commit
that referenced
this pull request
Jul 25, 2024
* feat(profiling): Write thread id to transactions table In addition to the profiler id, sometimes, we need the thread id to be able to link to the right thread within the profile. * add comment
Zylphrex
added a commit
that referenced
this pull request
Jul 25, 2024
* feat(profiling): Write thread id to transactions table (#6138) * feat(profiling): Write thread id to transactions table In addition to the profiler id, sometimes, we need the thread id to be able to link to the right thread within the profile. * add comment * handle when data is none
Zylphrex
added a commit
to getsentry/sentry
that referenced
this pull request
Jul 25, 2024
To generate a more accurate flamegraph, we want samples from the active thread. Depends on getsentry/snuba#6138
Christinarlong
pushed a commit
to getsentry/sentry
that referenced
this pull request
Jul 26, 2024
To generate a more accurate flamegraph, we want samples from the active thread. Depends on getsentry/snuba#6138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the profiler id, sometimes, we need the thread id to be able to link to the right thread within the profile.