feat(eap): Add index on project_id #6182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project_id is heavily used in queries, to narrow down to specific services. Add a bloom filter index on it to help improve query performance.
|
This PR has a migration; here is the generated SQL -- start migrations
-- forward migration events_analytics_platform : 0002_eap_spans_project_id_index
Local op: ALTER TABLE eap_spans_local ADD INDEX IF NOT EXISTS bf_project_id project_id TYPE bloom_filter GRANULARITY 1;
-- end forward migration events_analytics_platform : 0002_eap_spans_project_id_index
-- backward migration events_analytics_platform : 0002_eap_spans_project_id_index
Local op: ALTER TABLE eap_spans_local DROP INDEX IF EXISTS bf_project_id;
-- end backward migration events_analytics_platform : 0002_eap_spans_project_id_index |
volokluev
reviewed
Aug 7, 2024
| index_name="bf_project_id", | ||
| index_expression="project_id", | ||
| index_type="bloom_filter", | ||
| granularity=1, |
There was a problem hiding this comment.
how did you choose the granularity?
There was a problem hiding this comment.
These indexes use (relatively) low amounts of memory, so we have the granularity set to the minimum.
volokluev
approved these changes
Aug 7, 2024
|
PR reverted: 0fd7734 |
getsentry-bot
added a commit
that referenced
this pull request
Aug 7, 2024
This reverts commit cbbb3f8. Co-authored-by: evanh <2727124+evanh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project_id is heavily used in queries, to narrow down to specific services.
Add a bloom filter index on it to help improve query performance.