-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eap-spans): Drop ineffective indices to speed up insertion #6206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has a migration; here is the generated SQL -- start migrations
-- forward migration events_analytics_platform : 0005_drop_attribute_key_project_id_indexes
Local op: ALTER TABLE eap_spans_local DROP INDEX IF EXISTS bf_attr_str_0, DROP INDEX IF EXISTS bf_attr_str_1, DROP INDEX IF EXISTS bf_attr_str_2, DROP INDEX IF EXISTS bf_attr_str_3, DROP INDEX IF EXISTS bf_attr_str_4, DROP INDEX IF EXISTS bf_attr_str_5, DROP INDEX IF EXISTS bf_attr_str_6, DROP INDEX IF EXISTS bf_attr_str_7, DROP INDEX IF EXISTS bf_attr_str_8, DROP INDEX IF EXISTS bf_attr_str_9, DROP INDEX IF EXISTS bf_attr_str_10, DROP INDEX IF EXISTS bf_attr_str_11, DROP INDEX IF EXISTS bf_attr_str_12, DROP INDEX IF EXISTS bf_attr_str_13, DROP INDEX IF EXISTS bf_attr_str_14, DROP INDEX IF EXISTS bf_attr_str_15, DROP INDEX IF EXISTS bf_attr_str_16, DROP INDEX IF EXISTS bf_attr_str_17, DROP INDEX IF EXISTS bf_attr_str_18, DROP INDEX IF EXISTS bf_attr_str_19, DROP INDEX IF EXISTS bf_attr_num_0, DROP INDEX IF EXISTS bf_attr_num_1, DROP INDEX IF EXISTS bf_attr_num_2, DROP INDEX IF EXISTS bf_attr_num_3, DROP INDEX IF EXISTS bf_attr_num_4, DROP INDEX IF EXISTS bf_attr_num_5, DROP INDEX IF EXISTS bf_attr_num_6, DROP INDEX IF EXISTS bf_attr_num_7, DROP INDEX IF EXISTS bf_attr_num_8, DROP INDEX IF EXISTS bf_attr_num_9, DROP INDEX IF EXISTS bf_attr_num_10, DROP INDEX IF EXISTS bf_attr_num_11, DROP INDEX IF EXISTS bf_attr_num_12, DROP INDEX IF EXISTS bf_attr_num_13, DROP INDEX IF EXISTS bf_attr_num_14, DROP INDEX IF EXISTS bf_attr_num_15, DROP INDEX IF EXISTS bf_attr_num_16, DROP INDEX IF EXISTS bf_attr_num_17, DROP INDEX IF EXISTS bf_attr_num_18, DROP INDEX IF EXISTS bf_attr_num_19;
Local op: ALTER TABLE eap_spans_local DROP INDEX IF EXISTS bf_project_id;
-- end forward migration events_analytics_platform : 0005_drop_attribute_key_project_id_indexes
-- backward migration events_analytics_platform : 0005_drop_attribute_key_project_id_indexes
Local op: ALTER TABLE eap_spans_local ADD INDEX IF NOT EXISTS bf_attr_str_0 mapKeys(attr_str_0) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_1 mapKeys(attr_str_1) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_2 mapKeys(attr_str_2) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_3 mapKeys(attr_str_3) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_4 mapKeys(attr_str_4) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_5 mapKeys(attr_str_5) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_6 mapKeys(attr_str_6) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_7 mapKeys(attr_str_7) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_8 mapKeys(attr_str_8) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_9 mapKeys(attr_str_9) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_10 mapKeys(attr_str_10) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_11 mapKeys(attr_str_11) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_12 mapKeys(attr_str_12) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_13 mapKeys(attr_str_13) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_14 mapKeys(attr_str_14) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_15 mapKeys(attr_str_15) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_16 mapKeys(attr_str_16) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_17 mapKeys(attr_str_17) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_18 mapKeys(attr_str_18) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_str_19 mapKeys(attr_str_19) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_0 mapKeys(attr_num_0) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_1 mapKeys(attr_num_1) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_2 mapKeys(attr_num_2) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_3 mapKeys(attr_num_3) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_4 mapKeys(attr_num_4) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_5 mapKeys(attr_num_5) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_6 mapKeys(attr_num_6) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_7 mapKeys(attr_num_7) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_8 mapKeys(attr_num_8) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_9 mapKeys(attr_num_9) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_10 mapKeys(attr_num_10) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_11 mapKeys(attr_num_11) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_12 mapKeys(attr_num_12) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_13 mapKeys(attr_num_13) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_14 mapKeys(attr_num_14) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_15 mapKeys(attr_num_15) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_16 mapKeys(attr_num_16) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_17 mapKeys(attr_num_17) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_18 mapKeys(attr_num_18) TYPE bloom_filter GRANULARITY 1, ADD INDEX IF NOT EXISTS bf_attr_num_19 mapKeys(attr_num_19) TYPE bloom_filter GRANULARITY 1;
Local op: ALTER TABLE eap_spans_local ADD INDEX IF NOT EXISTS bf_project_id project_id TYPE bloom_filter GRANULARITY 1;
-- end backward migration events_analytics_platform : 0005_drop_attribute_key_project_id_indexes |
volokluev
approved these changes
Aug 14, 2024
this is breaking sentry
|
PR reverted: 6882653 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inserting data in this cluster is slow and having many indices is one of the reason. These indices we added were not as effective as we thought so it's harmless to remove them and will probably help insertion.